fix the fail2ban helper when using using --use_template arg #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
poke @alexAubin |
OniriCorpe
changed the title
alexAubin
reviewed
Nov 26, 2023
OniriCorpe
commented
Nov 26, 2023
alexAubin
reviewed
Nov 26, 2023
Co-authored-by: Alexandre Aubin <4533074+alexAubin@users.noreply.github.com>
alexAubin
reviewed
Nov 27, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
when the fail2ban helper is used with the --use_template argument, the
logpathvariable is not assigned, so there's an unbound errorthanks to @Psycojoker who helped me to understand the bug ^w^
Solution
if
logpathdoesn't exist, get the logpath from the template and assign it to thelogpathvariablereplace any
__VAR__in the logpath by their real variable using ynh_replace_varsPR Status
yolo
How to test
...