app.py, helpers: Reword YNH_APP_UPGRADE_TYPE #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove UPGRADE_FULL * rename DOWNGRADE_FORCED -> DOWNGRADE * rename UPGRADE_FORCED -> UPGRADE_SAME * keep the helper ynh_check_app_version_changed behaviour for reverse compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed because IMHO those
_FORCEDsuffixes are not really useful, and not actually used the way they should:https://github.com/search?q=org%3AYunoHost-Apps+UPGRADE_FORCED&type=code
The problem
useless code
Solution
remove code