Shellcheck : Fix hooks/ #2017
Open
Shellcheck : Fix hooks/ #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salamandar
force-pushed
the
shellcheck
branch
from
3047a5f to
b30a680
Compare
Salamandar
force-pushed
the
shellcheck
branch
from
a6872ad to
491e6d9
Compare
Salamandar
force-pushed
the
shellcheck
branch
from
a739987 to
df6dc90
Compare
Salamandar
force-pushed
the
shellcheck
branch
from
a53d95a to
e1a1452
Compare
Salamandar
force-pushed
the
shellcheck
branch
2 times, most recently
from
d1fd9f5 to
3730780
Compare
Salamandar
force-pushed
the
shellcheck
branch
from
3730780 to
d873ae0
Compare
…asses two empty args...
zamentur
requested changes
Jan 29, 2025
| set -Eeuo pipefail | ||
|
|
||
| # Source YNH helpers | ||
| # shellcheck source=../../helpers/helpers |
There was a problem hiding this comment.
I don't understand if it's really needed to add shellcheck source=../../helpers/helpers
| slapcat -b dc=yunohost,dc=org -l "${backup_dir}/dc=yunohost-dc=org.ldif" | ||
| echo "$backup_dir" > "$tmp_backup_dir_file" | ||
| if [ -e /etc/ldap/slapd.conf ]; then | ||
| curr_backend=$(grep '^database' /etc/ldap/slapd.conf | awk '{print $2}') |
There was a problem hiding this comment.
Is there a reason to remove the 2> /dev/null ?
There was a problem hiding this comment.
Suggested change
| curr_backend=$(grep '^database' /etc/ldap/slapd.conf | awk '{print $2}') | |
| curr_backend=$(grep '^database' /etc/ldap/slapd.conf 2> /dev/null | awk '{print $2}') |
| echo "$backup_dir" > "$tmp_backup_dir_file" | ||
| if [ -e /etc/ldap/slapd.conf ]; then | ||
| curr_backend=$(grep '^database' /etc/ldap/slapd.conf | awk '{print $2}') | ||
| if [ "$curr_backend" != 'mdb' ]; then |
There was a problem hiding this comment.
What if $curr_backend is empty string "" ? Are you sure it secure to remove [ -n "$curr_backend" ]
Suggested change
| if [ "$curr_backend" != 'mdb' ]; then | |
| if [ "$curr_backend" != 'mdb' ] && [ -n "$curr_backend" ]; then |
| @@ -18,9 +18,12 @@ | |||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| # | |||
|
|
|||
| # Exit hook on subcommand error or unset variable | |||
| set -e | |||
There was a problem hiding this comment.
Test seems to fail for regenconf nginx, so may be that's why we keep only set -e ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.