Skip to content

Commit

Permalink
Fix ESLint in Github actions (#237)
Browse files Browse the repository at this point in the history
* attempt fix pipeline

* Update eslint.yml

* bump actions upload sarif to v3
  • Loading branch information
YuraVolk authored Apr 14, 2024
1 parent ecc09bf commit aa31f35
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 7 deletions.
10 changes: 3 additions & 7 deletions .github/workflows/eslint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,11 @@ jobs:
npm install @microsoft/eslint-formatter-sarif@2.1.7
- name: Run ESLint
run: npx eslint .
--config .eslintrc.cjs
--ext .js,.jsx,.ts,.tsx
--format @microsoft/eslint-formatter-sarif
--output-file eslint-results.sarif
run: npm run lint:sarif
continue-on-error: true

- name: Upload analysis results to GitHub
uses: github/codeql-action/upload-sarif@v2
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: eslint-results.sarif
sarif_file: './'
wait-for-processing: true
1 change: 1 addition & 0 deletions lit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"setup": "npm install",
"lint": "eslint **/*.{ts,tsx} && npm run lint:local",
"lint:local": "lit-analyzer 'src/**/*.{js,ts}'",
"lint:sarif": "eslint **/*.{ts,tsx} --format @microsoft/eslint-formatter-sarif --output-file eslint-results-lit.sarif",
"type-check": "tsc --pretty --noEmit"
},
"author": "Yuriy Volkovskiy",
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"build:ci": "npm run setup && npm run build",
"setup": "lerna run setup",
"lint": "lerna run --parallel lint",
"lint:sarif": "lerna run lint:sarif --concurrency=1",
"type-check": "lerna run --parallel type-check",
"format": "prettier . --write"
},
Expand Down
1 change: 1 addition & 0 deletions react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"build": "webpack --mode production",
"setup": "npm install",
"lint": "eslint **/*.{ts,tsx}",
"lint:sarif": "eslint **/*.{ts,tsx} --format @microsoft/eslint-formatter-sarif --output-file eslint-results-react.sarif",
"type-check": "tsc --pretty --noEmit"
},
"author": "Yuriy Volkovskiy",
Expand Down
1 change: 1 addition & 0 deletions shared/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"build": "webpack --mode production",
"setup": "npm install",
"lint": "eslint **/*.ts",
"lint:sarif": "eslint **/*.ts --format @microsoft/eslint-formatter-sarif --output-file eslint-results-shared.sarif",
"type-check": "tsc --pretty --noEmit"
},
"author": "Yuriy Volkovskiy",
Expand Down
1 change: 1 addition & 0 deletions vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"build": "webpack --mode production",
"setup": "npm install",
"lint": "eslint **/*.{ts,vue}",
"lint:sarif": "eslint **/*.{ts,vue} --format @microsoft/eslint-formatter-sarif --output-file eslint-results-vue.sarif",
"type-check": "tsc --pretty --noEmit"
},
"author": "Yuriy Volkovskiy",
Expand Down

0 comments on commit aa31f35

Please sign in to comment.