test c# and python on container

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand · Sep 20, 2024 · 7519d56 · 7519d56
1 parent a055db1
commit 7519d56
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 13 deletions.
diff --git a/.github/workflows/build-python-wrapper/action.yml b/.github/workflows/build-python-wrapper/action.yml
@@ -42,7 +42,6 @@ runs:
 
         - name: Install Python software dependencies
           shell: bash
-          if: ${{ !contains(inputs.os, 'amazon-linux') }}
           run: |
               # Disregarding PEP 668 as it addresses package managers conflicts, which is not applicable in the CI scope.
               INSTALL_FLAGS=`if [[ "${{ inputs.os }}" =~ .*"macos".*  ]]; then echo "--break-system-packages"; else echo ""; fi`

diff --git a/.github/workflows/csharp.yml b/.github/workflows/csharp.yml
@@ -145,7 +145,8 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                #dotnet: ${{ fromJson(needs.get-containers.outputs.version-matrix-output) }}
+                # Don't use generated matrix for dotnet until net6.0 compatibility issues resolved on amazon linux
+                # dotnet: ${{ fromJson(needs.get-containers.outputs.version-matrix-output) }}
                 dotnet: [ "8.0" ]
                 engine: ${{ fromJson(needs.get-containers.outputs.engine-matrix-output) }}
                 host: ${{ fromJson(needs.get-containers.outputs.host-matrix-output) }}
@@ -155,9 +156,10 @@ jobs:
         steps:
             - name: Install git
               run: |
-                 yum update
-                 yum install -y git tar findutils libicu
-                 echo IMAGE=amazonlinux:latest | sed -r 's/:/-/g' >> $GITHUB_ENV
+                  yum update
+                  yum install -y git tar findutils libicu
+                  echo IMAGE=amazonlinux:latest | sed -r 's/:/-/g' >> $GITHUB_ENV
+            # Replace `:` in the variable otherwise it can't be used in `upload-artifact`
 
             - uses: actions/checkout@v4
               with:
@@ -167,7 +169,6 @@ jobs:
               uses: actions/setup-dotnet@v4
               with:
                   dotnet-version: ${{ matrix.dotnet }}
-#                  dotnet-version: '8.0'
 
             - name: Install shared software dependencies
               uses: ./.github/workflows/install-shared-dependencies
@@ -180,7 +181,6 @@ jobs:
             - name: Test dotnet ${{ matrix.dotnet }}
               working-directory: csharp
               run: dotnet test --framework net${{ matrix.dotnet }} "-l:html;LogFileName=TestReport.html" --results-directory . -warnaserror
-#              run: dotnet test --framework net8.0 "-l:html;LogFileName=TestReport.html" --results-directory . -warnaserror
 
             - name: Upload test reports
               if: always()

diff --git a/.github/workflows/java.yml b/.github/workflows/java.yml
@@ -166,8 +166,10 @@ jobs:
         steps:
             - name: Install git
               run: |
-                 yum update
-                 yum install -y git tar java-${{ matrix.java }}-amazon-corretto-devel.x86_64
+                  yum update
+                  yum install -y git tar java-${{ matrix.java }}-amazon-corretto-devel.x86_64
+                  echo IMAGE=amazonlinux:latest | sed -r 's/:/-/g' >> $GITHUB_ENV
+            # Replace `:` in the variable otherwise it can't be used in `upload-artifact`
 
             - uses: actions/checkout@v4
               with:
@@ -196,7 +198,7 @@ jobs:
               continue-on-error: true
               uses: actions/upload-artifact@v4
               with:
-                  name: test-reports-java-${{ matrix.java }}-${{ matrix.engine.type }}-${{ matrix.engine.version }}-${{ matrix.host.IMAGE }}-${{ matrix.host.ARCH }}
+                  name: test-reports-java-${{ matrix.java }}-${{ matrix.engine.type }}-${{ matrix.engine.version }}-${{ env.IMAGE }}-${{ matrix.host.ARCH }}
                   path: |
                       java/client/build/reports/**
                       java/integTest/build/reports/**

diff --git a/.github/workflows/node.yml b/.github/workflows/node.yml
@@ -201,6 +201,8 @@ jobs:
                      yum update
                      yum install -y git tar
                   fi
+                  echo IMAGE=amazonlinux:latest | sed -r 's/:/-/g' >> $GITHUB_ENV
+            # Replace `:` in the variable otherwise it can't be used in `upload-artifact`
 
             - uses: actions/checkout@v4
               with:
@@ -240,7 +242,7 @@ jobs:
               continue-on-error: true
               uses: actions/upload-artifact@v4
               with:
-                  name: test-report-node-${{ matrix.node }}-${{ matrix.engine.type }}-${{ matrix.engine.version }}-${{ matrix.host.IMAGE }}-${{ matrix.host.ARCH }}
+                  name: test-report-node-${{ matrix.node }}-${{ matrix.engine.type }}-${{ matrix.engine.version }}-${{ env.IMAGE }}-${{ matrix.host.ARCH }}
                   path: |
                       node/test-report*.html
                       utils/clusters/**

diff --git a/.github/workflows/python.yml b/.github/workflows/python.yml
@@ -259,7 +259,8 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-#                python: ${{ fromJson(needs.get-containers.outputs.version-matrix-output) }}
+                # Don't use generated matrix for python until compatibility issues resolved on amazon linux
+                # python: ${{ fromJson(needs.get-containers.outputs.version-matrix-output) }}
                 engine: ${{ fromJson(needs.get-containers.outputs.engine-matrix-output) }}
                 host: ${{ fromJson(needs.get-containers.outputs.host-matrix-output) }}
         container:
@@ -273,6 +274,8 @@ jobs:
                   python3 -m ensurepip --upgrade
                   python3 -m pip install --upgrade pip
                   python3 -m pip install mypy-protobuf virtualenv
+                  echo IMAGE=amazonlinux:latest | sed -r 's/:/-/g' >> $GITHUB_ENV
+            # Replace `:` in the variable otherwise it can't be used in `upload-artifact`
 
             - uses: actions/checkout@v4
               with:
@@ -298,7 +301,7 @@ jobs:
               continue-on-error: true
               uses: actions/upload-artifact@v4
               with:
-                  name: test-report-python-${{ matrix.python }}-${{ matrix.engine.type }}-${{ matrix.engine.version }}-${{ matrix.host.IMAGE }}-${{ matrix.host.ARCH }}
+                  name: test-report-python-${{ matrix.python }}-${{ matrix.engine.type }}-${{ matrix.engine.version }}-${{ env.IMAGE }}-${{ matrix.host.ARCH }}
                   path: |
                       python/python/tests/pytest_report.html
                       utils/clusters/**