Skip to content

Commit

Permalink
hardcode ports for SH runner
Browse files Browse the repository at this point in the history
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
  • Loading branch information
Yury-Fridlyand committed Feb 21, 2025
1 parent 49ce9a1 commit d53893b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions .github/workflows/csharp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ jobs:
- uses: actions/checkout@v4

- name: Set up dotnet ${{ matrix.dotnet }}
if: ${{ matrix.host.OS != 'windows' }}
uses: actions/setup-dotnet@v4
with:
dotnet-version: ${{ matrix.dotnet }}
Expand Down
7 changes: 4 additions & 3 deletions csharp/tests/Integration/IntegrationTestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ public IntegrationTestBase(IMessageSink diagnosticMessageSink)
Directory.Delete(Path.Combine(_scriptDir, "clusters"), true);

// Start cluster
TestConfiguration.CLUSTER_PORTS = StartRedis(true);
TestConfiguration.CLUSTER_PORTS = [7000, 7001, 7002, 7003, 7004, 7005]; //StartRedis(true);
// Start standalone
TestConfiguration.STANDALONE_PORTS = StartRedis(false);
TestConfiguration.STANDALONE_PORTS = [6379];// StartRedis(false);
// Get redis version
TestConfiguration.REDIS_VERSION = GetRedisVersion();
TestConfiguration.REDIS_VERSION = new Version("8.0.0");// GetRedisVersion();

TestConsoleWriteLine($"Cluster ports = {string.Join(',', TestConfiguration.CLUSTER_PORTS)}");
TestConsoleWriteLine($"Standalone ports = {string.Join(',', TestConfiguration.STANDALONE_PORTS)}");
Expand All @@ -73,6 +73,7 @@ internal List<uint> StartRedis(bool cluster, bool tls = false, string? name = nu
/// </summary>
internal void StopRedis(bool keepLogs, string? name = null)

Check failure on line 74 in csharp/tests/Integration/IntegrationTestBase.cs

View workflow job for this annotation

GitHub Actions / test-csharp (8.0, redis, 6.2, always, ubuntu, linux, ubuntu-latest, x64, x86_64-unknown-linux-gnu...

Parameter 'keepLogs' can be removed; its initial value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0060)

Check failure on line 74 in csharp/tests/Integration/IntegrationTestBase.cs

View workflow job for this annotation

GitHub Actions / test-csharp (8.0, redis, 6.2, always, ubuntu, linux, ubuntu-latest, x64, x86_64-unknown-linux-gnu...

Parameter 'name' can be removed; its initial value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0060)
{
return;
string cmd = $"stop --prefix {name ?? "cluster"} {(keepLogs ? "--keep-folder" : "")}";

Check failure on line 77 in csharp/tests/Integration/IntegrationTestBase.cs

View workflow job for this annotation

GitHub Actions / test-csharp (8.0, redis, 6.2, always, ubuntu, linux, ubuntu-latest, x64, x86_64-unknown-linux-gnu...

Unreachable code detected
_ = RunClusterManager(cmd, true);
}
Expand Down

0 comments on commit d53893b

Please sign in to comment.