[do not merge] Introduce optimized from_u64 function for conversion to Montgomery form #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sragss
reviewed
Feb 28, 2024
| @@ -64,6 +64,10 @@ pub trait FpConfig<const N: usize>: Send + Sync + 'static + Sized { | |||
| /// which works for every modulus. | |||
| const SQRT_PRECOMP: Option<SqrtPrecomputation<Fp<Self, N>>>; | |||
|
|
|||
| /// Precomputed lookup table for values 0..2^16 in Montgomery form. | |||
| /// Otherwise, conversion to Montgomery form requires a multiplication by R^2. | |||
| const SMALL_ELEMENT_MONTGOMERY_PRECOMP: [Fp<Self, N>; PRECOMP_TABLE_SIZE]; | |||
There was a problem hiding this comment.
Have you considered doing this with lazy_static!() or include_bytes!() + build.rs?
| hi[i] = adc!(hi[i], carry, &mut carry2); | ||
| } | ||
|
|
||
| (self.0).0 = hi; |
|
I'd suggest feature flagging this |
moodlezoup
force-pushed
the
optimize/field-from-u64
branch
from
6c5bac5 to
ccd64e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge, for visibility only