add SSTORE and SLOAD to traces #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
0xkarmacoma
commented
Feb 12, 2025
0xkarmacoma
commented
|
will add a |
daejunpark
reviewed
Feb 12, 2025
|
|
||
| def sstore(self, ex: Exec, addr: Any, loc: Any, val: Any) -> None: | ||
| ex.context.trace.append(StorageWrite(addr, loc, val)) | ||
|
|
There was a problem hiding this comment.
do you want to add this event even in the case of raising WriteInStaticContext below?
There was a problem hiding this comment.
yes, I think it's going to be useful for debugging - so you know what it tried to write that caused the revert
in 4685084 |
daejunpark
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.