-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename optimism to op-mainnet #422
chore: rename optimism to op-mainnet #422
Conversation
Let's update the operationsolarstorm endpoint as well for consistency. I'll make sure to add an alias to that url. |
@ncitron Sure. Btw, I ran Output:
Is this something I should be concerned about? |
Yeah thats fine. Those env vars get injected by our CI which is why it fails locally. |
Did you push your commit to update the URLs? |
What should be the new URLs? |
We should change all instances of |
And this?
|
No this stays the same |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Before we merge can you run |
Done. What about clippy errors? |
Any dependency? |
Closes #421