Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CONTRIBUTING.md guide for releasing process #1063

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ttypic
Copy link
Contributor

@ttypic ttypic commented Feb 7, 2025

Update CONTRIBUTING.md guide for releasing process

Summary by CodeRabbit

  • Documentation
    • Updated the release process guidelines to reflect a streamlined, automated workflow for creating and publishing releases.
    • Removed outdated instructions for manual packaging steps, simplifying the contributor workflow.

@ttypic ttypic requested a review from sacOO7 February 7, 2025 16:42
Copy link

coderabbitai bot commented Feb 7, 2025

Walkthrough

The changes update the CONTRIBUTING.md file. A section describing the fat JAR build using “./gradlew java:fullJar” has been removed. The release process steps have been revised and renumbered to incorporate a new workflow. The documentation now instructs users to create a release and tag it on GitHub, followed by using a GitHub action to publish the release, replacing prior manual instructions. No modifications have been made to exported or public entities.

Changes

File Change Summary
CONTRIBUTING.md Removed the fat JAR build instruction (“./gradlew java:fullJar”) and updated the release steps to use GitHub releases and actions for a streamlined workflow.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub
    participant GA as GitHub Action

    Dev->>GH: Create release & tag on GitHub
    GH->>GA: Trigger GitHub action for release
    GA->>GH: Publish release artifacts
Loading

Poem

I'm a little rabbit, hopping with glee,
Changes in the docs set our workflow free.
The fat jar trick has hopped away,
In its place, GitHub actions now rule the day!
Code paths cleared and steps aligned,
I cheer and nibble on the progress signed!
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
CONTRIBUTING.md (2)

230-233: Clarify the Changelog Generator Instructions
The updated changelog generation block now explains the command and the token generation process. Consider adding a brief example of the expected output from the command or additional tips on how to merge the generated file (delta.md) into CHANGELOG.md. Also, note that the static analysis feedback regarding adverbs ending in “ly” is minor and can be optionally addressed.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~230-~230: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ...d to run will look something like this: `github_changelog_generator -u ably -p ably-java --since-tag v1.2.3 --output delta.md --...

(HYPHENATED_LY_ADVERB_ADJECTIVE)


237-239: Review the GitHub Release Automation Steps
The new instructions for creating the release tag on GitHub and using the GitHub Action to publish the release provide a streamlined workflow compared to the previous manual process. Ensure that readers are aware of any prerequisites (e.g., necessary permissions or configuration of the GitHub Action) to avoid confusion during the release process.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19d3ef0 and e9cd749.

📒 Files selected for processing (1)
  • CONTRIBUTING.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
CONTRIBUTING.md

[uncategorized] ~230-~230: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ...d to run will look something like this: `github_changelog_generator -u ably -p ably-java --since-tag v1.2.3 --output delta.md --...

(HYPHENATED_LY_ADVERB_ADJECTIVE)

⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: check (29)
  • GitHub Check: check-rest
  • GitHub Check: check-realtime-okhttp
  • GitHub Check: check (24)
  • GitHub Check: check (21)
  • GitHub Check: check-realtime
  • GitHub Check: check-rest-okhttp
  • GitHub Check: check (19)

CONTRIBUTING.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants