SMQ-2704 - Update listing of group hierarchy #2710
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
==========================================
- Coverage 42.13% 41.48% -0.65%
==========================================
Files 351 24 -327
Lines 48109 5093 -43016
==========================================
- Hits 20269 2113 -18156
+ Misses 25631 2814 -22817
+ Partials 2209 166 -2043 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dborovcanin
force-pushed
the
smq2704-groups
branch
from
deb1e34 to
19abcf6
Compare
felixgateru
force-pushed
the
smq2704-groups
branch
from
19abcf6 to
057f724
Compare
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
felixgateru
force-pushed
the
smq2704-groups
branch
from
057f724 to
f1a7a63
Compare
arvindh123
requested changes
Mar 13, 2025
Comment on lines
183
to
189
| return HierarchyPage{}, errors.Wrap(svcerr.ErrViewEntity, err) | ||
| } | ||
| hids := svc.getGroupIDs(hp.Groups) | ||
| ids, err := svc.filterAllowedGroupIDsOfUserID(ctx, session.DomainUserID, "read_permission", hids) | ||
| ids, err := svc.filterAllowedGroupIDsOfUserID(ctx, session.DomainID, session.UserID, hids) | ||
| if err != nil { | ||
| return HierarchyPage{}, errors.Wrap(svcerr.ErrViewEntity, err) | ||
| } |
There was a problem hiding this comment.
We should use different approach, This is legacy way which is inefficient and will not scale.
We should follow the approach used for listing groups.
I will come up with SQL, or idea to approach this..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor as it updates the list groups hierarchy fucntionality to follow the new listing methodology
What does this do?
This pr refactors listing groups for a user from SpiceDB to the groups repo method.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have updated tests for my changes.
Did you document any new/modified feature?
No
Notes
None