-
Notifications
You must be signed in to change notification settings - Fork 672
Fix invitation acceptance logic and update permission constant naming #2803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2803 +/- ##
==========================================
+ Coverage 27.55% 28.28% +0.73%
==========================================
Files 351 30 -321
Lines 55347 5462 -49885
==========================================
- Hits 15251 1545 -13706
+ Misses 39340 3822 -35518
+ Partials 756 95 -661 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -42,7 +42,7 @@ const ( | |||
readPermission = "read_permission" | |||
deletePermission = "delete_permission" | |||
manageRolePermission = "manage_role_permission" | |||
addRoleUsersPermission = "add_role_users_permission" | |||
AddRoleUsersPermission = "add_role_users_permission" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this operations is needed some where else ? Why it is exported ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
if err := am.extAuthorize(ctx, auth.EncodeDomainUserID(domainID, inv.InvitedBy), domains.AddRoleUsersPermission, policies.DomainType, domainID); err == nil {
return err
}
```
@SammyOina Please rebase. |
@SammyOina Please rebase. @arvindh123 Please review. |
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes