feat: Adding a few changes to test seeding algorithm (#4075)

This PR includes a few changes to facilitate performance studies for the seeding algorithm

@pbutti, @benjaminhuth 


<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

- **New Features**  
  - Enhanced seeding capability with new configuration options for additional filtering and customizable seed naming.  
  - Introduced a demonstration script that simplifies data reading and seeding, now featuring improved debug logging.

- **Chores**  
  - Optimized tracking criteria by refining selection thresholds and updating filtering parameters for improved performance.  
  - Added debug logging to track space point creation for better visibility during processing.  
  - Introduced a new parameter for occupancy configuration in the seeding algorithm.  
  - Updated filtering criteria in the reader to focus on space points.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Examples/Algorithms/TrackFinding/include/ActsExamples/TrackFinding/SeedingAlgorithm.hpp

@@ -111,7 +111,7 @@ class SeedingAlgorithm final : public IAlgorithm {
   WriteDataHandle<SimSeedContainer> m_outputSeeds{this, "OutputSeeds"};
 
   static inline bool itkFastTrackingCuts(float bottomRadius, float cotTheta) {
-    static float rMin = 50.;
+    static float rMin = 45.;
     static float cotThetaMax = 1.5;
 
     if (bottomRadius < rMin &&
@@ -125,7 +125,7 @@ class SeedingAlgorithm final : public IAlgorithm {
     // At small r we remove points beyond |z| > 200.
     float r = sp.radius();
     float zabs = std::abs(sp.z());
-    if (zabs > 200. && r < 50.) {
+    if (zabs > 200. && r < 45.) {
       return false;
     }
 

Examples/Io/Root/src/RootAthenaDumpReader.cpp

@@ -626,6 +626,8 @@ RootAthenaDumpReader::readSpacepoints(
   ACTS_DEBUG("Created " << spacePoints.size() << " overall space points");
   ACTS_DEBUG("Created " << pixelSpacePoints.size() << " "
                         << " pixel space points");
+  ACTS_DEBUG("Created " << stripSpacePoints.size() << " "
+                        << " strip space points");
 
   return {spacePoints, pixelSpacePoints, stripSpacePoints};
 }

Examples/Python/python/acts/examples/itk.py

@@ -581,6 +581,7 @@ def itkSeedingAlgConfig(
         zBinNeighborsTop=zBinNeighborsTop,
         zBinNeighborsBottom=zBinNeighborsBottom,
         numPhiNeighbors=numPhiNeighbors,
+        useExtraCuts=highOccupancyConfig,
     )
 
     return (

Examples/Python/python/acts/examples/reconstruction.py

@@ -636,6 +636,7 @@ def addStandardSeeding(
     seedFilterConfigArg: SeedFilterConfigArg,
     spacePointGridConfigArg: SpacePointGridConfigArg,
     logLevel: acts.logging.Level = None,
+    outputSeeds: str = "seeds",
 ):
     """adds standard seeding
     For parameters description see addSeeding
@@ -762,7 +763,7 @@ def addStandardSeeding(
     seedingAlg = acts.examples.SeedingAlgorithm(
         level=logLevel,
         inputSpacePoints=[spacePoints],
-        outputSeeds="seeds",
+        outputSeeds=outputSeeds,
         **acts.examples.defaultKWArgs(
             allowSeparateRMax=seedingAlgorithmConfigArg.allowSeparateRMax,
             zBinNeighborsTop=seedingAlgorithmConfigArg.zBinNeighborsTop,

Examples/Python/src/Input.cpp

@@ -100,9 +100,9 @@ void addInput(Context& ctx) {
       ActsExamples::RootAthenaDumpReader, mex, "RootAthenaDumpReader", treename,
       inputfile, outputMeasurements, outputPixelSpacePoints,
       outputStripSpacePoints, outputSpacePoints, outputClusters,
-      outputMeasurementParticlesMap, outputParticles, onlyPassedParticles,
-      skipOverlapSPsPhi, skipOverlapSPsEta, geometryIdMap, trackingGeometry,
-      absBoundaryTolerance);
+      outputMeasurementParticlesMap, outputParticles, onlySpacepoints,
+      onlyPassedParticles, skipOverlapSPsPhi, skipOverlapSPsEta, geometryIdMap,
+      trackingGeometry, absBoundaryTolerance);
 
 #ifdef WITH_GEOMODEL_PLUGIN
   ACTS_PYTHON_DECLARE_READER(ActsExamples::RootAthenaDumpGeoIdCollector, mex,

Examples/Scripts/Python/reader_and_seeding.py

@@ -0,0 +1,59 @@
+import sys
+from pathlib import Path
+
+import acts.examples
+import acts
+
+from acts.examples import (
+    CsvSpacePointReader,
+    TrackParamsEstimationAlgorithm,
+    SeedingPerformanceWriter,
+)
+from acts.examples.reconstruction import (
+    addStandardSeeding,
+)
+
+from acts.examples.itk import itkSeedingAlgConfig, InputSpacePointsType
+
+
+s = acts.examples.Sequencer(events=1, numThreads=1, outputDir="output")
+
+# loggingLevel = acts.logging.INFO
+loggingLevel = acts.logging.DEBUG
+
+s.addReader(
+    acts.examples.RootAthenaDumpReader(
+        level=loggingLevel,
+        treename="GNN4ITk",
+        inputfile="Dump_GNN4Itk.root",
+        onlySpacepoints=True,
+        outputPixelSpacePoints="pixel_spacepoints",
+        outputStripSpacePoints="strip_spacepoints",
+        outputSpacePoints="spacepoints",
+    )
+)
+
+
+# run pixel seeding
+seeding_pixel = addStandardSeeding(
+    s,
+    "pixel_spacepoints",
+    *acts.examples.itk.itkSeedingAlgConfig(
+        InputSpacePointsType.PixelSpacePoints, highOccupancyConfig=True
+    ),
+    logLevel=loggingLevel,
+    outputSeeds="pixel_seeds"
+)
+
+
+# run strip seeding
+seeding_strip = addStandardSeeding(
+    s,
+    "strip_spacepoints",
+    *acts.examples.itk.itkSeedingAlgConfig(InputSpacePointsType.StripSpacePoints),
+    logLevel=acts.logging.DEBUG,
+    outputSeeds="strip_seeds"
+)
+
+
+s.run()