Skip to content

Commit

Permalink
refactor: Remove calculateTrackQuantities from Core CKF (#3567)
Browse files Browse the repository at this point in the history
Originally #3536 but reverted with #3565 due to FPEs in Athena.

---

Remove `calculateTrackQuantities` which recalculates measurements and holes from the track since we already accumulate these numbers inside the CKF actor.
  • Loading branch information
andiwand authored Aug 29, 2024
1 parent 809b378 commit d6b112d
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions Core/include/Acts/TrackFinding/CombinatorialKalmanFilter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -982,6 +982,8 @@ class CombinatorialKalmanFilter {
typeFlags.set(TrackStateFlag::MeasurementFlag);
// Increment number of measurements
newBranch.nMeasurements()++;
newBranch.nDoF() += trackState.calibratedSize();
newBranch.chi2() += trackState.chi2();
} else {
ACTS_WARNING("Cannot handle this track state flags");
continue;
Expand Down Expand Up @@ -1330,10 +1332,6 @@ class CombinatorialKalmanFilter {
return error.error();
}

for (const auto& track : combKalmanResult.collectedTracks) {
calculateTrackQuantities(track);
}

return std::move(combKalmanResult.collectedTracks);
}
};
Expand Down

0 comments on commit d6b112d

Please sign in to comment.