-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Start to migrate the R4-MS segment fit #4108
Draft
junggjo9
wants to merge
3
commits into
acts-project:main
Choose a base branch
from
junggjo9:CsvHough
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
// This file is part of the ACTS project. | ||
// | ||
// Copyright (C) 2025 CERN for the benefit of the ACTS project | ||
// | ||
// This Source Code Form is subject to the terms of the Mozilla Public | ||
// License, v. 2.0. If a copy of the MPL was not distributed with this | ||
// file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
#pragma once | ||
|
||
#include "Acts/Definitions/Algebra.hpp" | ||
|
||
#include <type_traits> | ||
|
||
|
||
namespace Acts{ | ||
/** @brief Concept definition of the station space points. They're primarly used in composite detectors, | ||
* like the Muon chambers in side the ATLAS experiment. The chambers usually consist of few layers | ||
* of drift tubes which maybe sandwiched by other strip detector layers to measure the local coordinates | ||
* on the reference plane the particle's passage. | ||
* | ||
* To describe the | ||
*/ | ||
template <typename SpacePointType> | ||
concept StationSpacePoint = requires(SpacePointType sp) { | ||
/** @brief Local position of the space point measurement. It'either | ||
* the position of the wire or the position of the fired strip in the chamber */ | ||
{ sp.localPosition() } -> std::same_as<const Acts::Vector3&>; | ||
/** @brief Orientation of the sensor, which is either the wire orientation or | ||
* the strip orientation. Travelling along the direction does not alter the residual */ | ||
{ sp.sensorDirection()} -> std::same_as<const Acts::Vector3&>; | ||
/** @brief Normal vector on the strip-plane. */ | ||
{ sp.stripPlaneNormal()} -> std::same_as<const Acts::Vector3&>; | ||
/** @brief Radius of the tube drift-measurement. The returned value is zero for strip measurements */ | ||
{ sp.driftRadius() } -> std::same_as<double>; | ||
/** @brief Time when the measurement was taken */ | ||
{ sp.time()} -> std::same_as<double>; | ||
}; | ||
|
||
template<StationSpacePoint> | ||
class MeasurementSorter{ | ||
public: | ||
MeasurementSorter() = default; | ||
}; | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
Examples/Framework/include/ActsExamples/EventData/MuonSpacePoint.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
|
||
#pragma once | ||
|
||
#include "Acts/EventData/StationSpacePoint.hpp" | ||
|
||
namespace Acts{ | ||
class MuonSpacePoint { | ||
public: | ||
/** @brief Return the local meaurement position */ | ||
const Acts::Vector3& localPosition() const{ | ||
return m_pos; | ||
} | ||
/** @brief Return the local sensor direction */ | ||
const Acts::Vector3& sensorDirection() const{ | ||
return m_dir; | ||
} | ||
/** @brief Return the normal vector to the plane */ | ||
const Acts::Vector3& stripPlaneNormal() const { | ||
return m_pos; | ||
} | ||
/** @brief Return the drift radius */ | ||
double driftRadius() const{ | ||
return m_radius; | ||
} | ||
/** @brief Return the measurement time */ | ||
double time() const { | ||
return m_time; | ||
} | ||
/** @brief Define the space point coordinates. | ||
* @param pos: Space point position | ||
* @param sensorDir: Direction of the sensor */ | ||
void defineCoordinates(Acts::Vector3&& pos, | ||
Acts::Vector3&& sensorDir){ | ||
m_pos = std::move(pos); | ||
m_dir = std::move(sensorDir); | ||
} | ||
/** @brief Define the space point normal*/ | ||
void defineNormal(Acts::Vector3&& norm) { | ||
m_norm = std::move(norm); | ||
} | ||
/** @brief Define the space point radius */ | ||
void setRadius(const double r) { | ||
m_radius = r; | ||
} | ||
/** @brief Define the time of the space point measurement */ | ||
void setTime(const double t){ | ||
m_time = t; | ||
} | ||
private: | ||
Acts::Vector3 m_pos{Acts::Vector3::Zero()}; | ||
Acts::Vector3 m_dir{Acts::Vector3::Zero()}; | ||
Acts::Vector3 m_norm{Acts::Vector3::Zero()}; | ||
double m_radius{0.}; | ||
double m_time{0.}; | ||
|
||
}; | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A disturbance in the Force, I sense. Wrong member variable returned, it is.
Return m_pos instead of m_norm, this function does. A critical error this is, young padawan.
Fix this, you must:
📝 Committable suggestion