Parse addresses in strict mode (#28)

adam12 · Feb 8, 2024 · 4466d72 · 4466d72
1 parent 1c68292
commit 4466d72
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/ecto_network/inet.ex b/lib/ecto_network/inet.ex
@@ -33,7 +33,7 @@ defmodule EctoNetwork.INET do
       address
       |> String.trim()
       |> String.to_charlist()
-      |> :inet.parse_address()
+      |> :inet.parse_strict_address()
 
     parsed_netmask = cast_netmask(netmask, parsed_address)
 

diff --git a/test/ecto_network_test.exs b/test/ecto_network_test.exs
@@ -65,6 +65,14 @@ defmodule EctoNetworkTest do
              {"is invalid", [type: EctoNetwork.INET, validation: :cast]}
   end
 
+  test "converts shortened address into changeset error" do
+    changeset = Device.changeset(%Device{}, %{ip_address: "111"})
+    {:error, changeset} = TestRepo.insert(changeset)
+
+    assert changeset.errors[:ip_address] ==
+             {"is invalid", [type: EctoNetwork.INET, validation: :cast]}
+  end
+
   test "converts ipv4 with incomplete CIDR into changeset error" do
     changeset = Device.changeset(%Device{}, %{ip_address: "1.2.3.0/"})
     {:error, changeset} = TestRepo.insert(changeset)