Skip to content

Commit

Permalink
warn on false negatives if repro_compare.sh is run after comparable_p…
Browse files Browse the repository at this point in the history
…atch.sh in ReproducibleBuilds.md
  • Loading branch information
judovana authored Jan 31, 2025
1 parent eb5f754 commit d352951
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tooling/reproducible/ReproducibleBuilds.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ The patching process involves:
- Remove any non-deterministic build process artifact strings, like Manifest Created-By stamps.
- Zero out CRC in .gnu_debuglink ELF sections to eliminate .debuginfo-induced differences.

**warning:** If you run `comparable_patch.sh`, do not use `repro_compare.sh` for final comparison. You would get false negatives. Run plain `diff jdk1 jdk2` with any switches you need.

### How to setup and run comparable_patch.sh on Windows

#### Tooling setup:
Expand Down

0 comments on commit d352951

Please sign in to comment.