Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] MrSEQLClassifier wrapper #1756

Merged
merged 15 commits into from
Sep 18, 2024
Merged

[ENH] MrSEQLClassifier wrapper #1756

merged 15 commits into from
Sep 18, 2024

Conversation

MatthewMiddlehurst
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst commented Jul 3, 2024

Fixes #1738

What does this implement/fix? Explain your changes.

Start of a mrseql wrapper. Unfortunately, I can't quite find how to parameterise it currently after installing on Windows 🙂.

If anyone can find it in the source that that would be helpful: https://github.com/lnthach/Mr-SEQL

Does your contribution introduce a new dependency? If yes, which one?

mrseql

@MatthewMiddlehurst MatthewMiddlehurst added the interfacing algorithms Interfacing existing algorithms/estimators for other packages label Jul 3, 2024
@aeon-actions-bot aeon-actions-bot bot added classification Classification package enhancement New feature, improvement request or other non-bug code enhancement labels Jul 3, 2024
@aeon-actions-bot
Copy link
Contributor

aeon-actions-bot bot commented Jul 3, 2024

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst
Copy link
Member Author

@lnthach Hi Thach, I am having a bit of trouble figuring out what parameters your MrSEQL pypi package has and what defaults I should set for them. Would you be able to comment and help me with this?

@lnthach
Copy link

lnthach commented Jul 31, 2024

@MatthewMiddlehurst Hi Matthew, I just had a quick look. I think your job would be easier if I make some changes on my side. At this stage I believe it wouldn't pass the checks anyway. I will get back to you later once it's updated (asap).

@lnthach
Copy link

lnthach commented Aug 2, 2024

@MatthewMiddlehurst Hi Matthew, I just updated mrseql (v0.0.4) on pypi so I hope it would make things easier for you. I also remove sktime dependency but use fftw3 library instead (same dependencies as mrsqm).

Currently there are three parameters for MrSEQLClassifier and the default values are as follows:
MrSEQLClassifier(seql_mode='fs', symrep=('sax'), custom_config=None)

Please let me know if it works for you.

@aeon-actions-bot aeon-actions-bot bot added the codecov actions Run the codecov action on a PR label Aug 5, 2024
@MatthewMiddlehurst
Copy link
Member Author

@lnthach Thanks for this. Raised the version found but it seems to be failing to install on our Linux runner (https://github.com/aeon-toolkit/aeon/actions/runs/10247769782/job/28347641403?pr=1756). mrsqm installs fine by the look of things

@lnthach
Copy link

lnthach commented Aug 5, 2024

@MatthewMiddlehurst This one is strange. Both uses the same sfa implementation so both depends on fftw3. One possible reason is that mrsqm installed from built distribution hence the installation somehow bypassed this dependency (not sure if this is possible to be honest). I have some issues with generating the built distribution for mrseql so I uploaded only the source distribution. Do you think this could be the reason ?

@MatthewMiddlehurst
Copy link
Member Author

@lnthach I think thats likely, not really sure how to resolve it through as I dont have much experience wrapping C, let alone distributing it 🙂. If the parameters used are the same I can restrict it to 0.0.2 for now?

@lnthach
Copy link

lnthach commented Aug 6, 2024

@MatthewMiddlehurst I just uploaded the built distribution for v0.0.4. Could please you check if it still fails ?

@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review August 14, 2024 11:09
@MatthewMiddlehurst
Copy link
Member Author

Seems to all be running fine @lnthach

@MatthewMiddlehurst MatthewMiddlehurst merged commit 11e3408 into main Sep 18, 2024
16 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the mm/mrseql branch September 18, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package codecov actions Run the codecov action on a PR enhancement New feature, improvement request or other non-bug code enhancement interfacing algorithms Interfacing existing algorithms/estimators for other packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Categorisation of MrSQM and MrSEQL algorithms
3 participants