Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] change input type for MrSQMClassifier and deprecate prior to moving package #1735

Merged
merged 13 commits into from
Jul 3, 2024

Conversation

TonyBagnall
Copy link
Contributor

@TonyBagnall TonyBagnall commented Jun 27, 2024

fixes #1685
fixes #1738

currently MrSQM used the deprecated "nested_univ" internal type. In order to allow that to be removed, this PR moves the conversion from numpy 3D to pd.DataFrame with each cell a series to the only place its used, this function

@TonyBagnall TonyBagnall added the classification Classification package label Jun 27, 2024
@aeon-actions-bot aeon-actions-bot bot added the enhancement New feature, improvement request or other non-bug code enhancement label Jun 27, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I would have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)

@TonyBagnall TonyBagnall changed the title [ENH] change input type for MrSQMClassifier [ENH] change input type for MrSQMClassifier and deprecate prior to moving package Jul 2, 2024
Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix linked issues. LGTM !

@TonyBagnall TonyBagnall merged commit d6a6431 into main Jul 3, 2024
14 checks passed
@TonyBagnall TonyBagnall deleted the ajb/mrsqm branch July 3, 2024 08:10
@lnthach
Copy link

lnthach commented Jul 16, 2024

Hi @TonyBagnall
Regarding the input type, the latest mrsqm (0.0.7) supports numpy 3D so the conversion shouldn't be needed. Can I create another pull request to remove the conversion ?

@MatthewMiddlehurst
Copy link
Member

@lnthach Hi Thach, I have done this as part of #1756 actually 🙂. Feel free to make your own PR if you want however as that has other stuff.

I saw that you had uploaded MrSEQL to pypi so was interested in adding a wrapper for it, but was having a bit of trouble figuring out what parameters it has and what defaults I should set for them. Would you be able to help me with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Categorisation of MrSQM and MrSEQL algorithms [ENH] MrSQM uses nested data frames
4 participants