-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] change input type for MrSQMClassifier and deprecate prior to moving package #1735
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should fix linked issues. LGTM !
Hi @TonyBagnall |
@lnthach Hi Thach, I have done this as part of #1756 actually 🙂. Feel free to make your own PR if you want however as that has other stuff. I saw that you had uploaded |
fixes #1685
fixes #1738
currently MrSQM used the deprecated "nested_univ" internal type. In order to allow that to be removed, this PR moves the conversion from numpy 3D to pd.DataFrame with each cell a series to the only place its used, this function