-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add type hints to _shapelet_transform.py __init__ method #1926
[ENH] add type hints to _shapelet_transform.py __init__ method #1926
Conversation
Thank you for contributing to
|
ad1dc90
to
aee8d79
Compare
aee8d79
to
1621fb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I just checked that time limit and contact num shapelets can in fact be ints and floats and its fine
Not a blocker, fine with that as is, but is it better to do |
0f10d25
to
df48f11
Compare
I agree with Matthew's comment, and updated all "Union[int, float]" to "float". Sorry to hadifawaz1999 and chrisholder, I wasn't trying to add you all as reviewers. My guess is updating my local branch with (git pull) the new aeon repo commits indirectly added them |
df48f11
to
ec2bde6
Compare
Reference Issues/PRs
What does this implement/fix? Explain your changes.
__init__
method in _shapelet_transform.pyDoes your contribution introduce a new dependency? If yes, which one?
Any other comments?