-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add type hints for shapelet-based collection transformation. #1910
Comments
@Datadote If this one is OK for you, you can assign yourself to it ! |
Aeon-Assign bot assign @Datadote |
I don't remember if we have a bot for this, but you can do it manually on the Assignees tab on the right side, I'll do it for you this time. Happy coding, and thanks for contributing ! |
There was an error in the docs that we have now fixed, but have to wait for a release for it to appear on the stable branch. Have to start with @aeon-actions-bot |
I think you need write access to manually assign yourself |
Yep, I don't have access to manually assign myself (Tried on other issues). I started a draft pull request with type hints, and some styling questions in #1926 . Thank you for the help |
Aeon-Assign bot assign @aryanpola |
Describe the issue
Other modules are increasingly using type hints in the function declaration, the shapelet-based tranformation module should do the same.
Suggest a potential alternative/fix
Add type hints to algorithms in
aeon/transformations/collection/shapelet_based
. One PR can be opened for each algorithm if preferred, as some are quite large.Additional context
If you have any question, don't hesitate to ask directly here or contact us on Slack!
The text was updated successfully, but these errors were encountered: