Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add type hints for shapelet-based collection transformation. #1910

Closed
baraline opened this issue Aug 5, 2024 · 7 comments
Closed

[DOC] Add type hints for shapelet-based collection transformation. #1910

baraline opened this issue Aug 5, 2024 · 7 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers transformations Transformations package

Comments

@baraline
Copy link
Member

baraline commented Aug 5, 2024

Describe the issue

Other modules are increasingly using type hints in the function declaration, the shapelet-based tranformation module should do the same.

Suggest a potential alternative/fix

Add type hints to algorithms in aeon/transformations/collection/shapelet_based. One PR can be opened for each algorithm if preferred, as some are quite large.

Additional context

If you have any question, don't hesitate to ask directly here or contact us on Slack!

@baraline baraline added documentation Improvements or additions to documentation good first issue Good for newcomers transformations Transformations package labels Aug 5, 2024
@baraline
Copy link
Member Author

baraline commented Aug 5, 2024

@Datadote If this one is OK for you, you can assign yourself to it !

@Datadote
Copy link
Contributor

Datadote commented Aug 5, 2024

Aeon-Assign bot assign @Datadote

@baraline
Copy link
Member Author

baraline commented Aug 5, 2024

I don't remember if we have a bot for this, but you can do it manually on the Assignees tab on the right side, I'll do it for you this time. Happy coding, and thanks for contributing !

@baraline baraline assigned baraline and Datadote and unassigned baraline Aug 5, 2024
@MatthewMiddlehurst
Copy link
Member

There was an error in the docs that we have now fixed, but have to wait for a release for it to appear on the stable branch. Have to start with @aeon-actions-bot

@MatthewMiddlehurst
Copy link
Member

I think you need write access to manually assign yourself

@Datadote
Copy link
Contributor

Datadote commented Aug 7, 2024

Yep, I don't have access to manually assign myself (Tried on other issues).

I started a draft pull request with type hints, and some styling questions in #1926 . Thank you for the help

@aryanpola
Copy link
Contributor

Aeon-Assign bot assign @aryanpola

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers transformations Transformations package
Projects
None yet
Development

No branches or pull requests

4 participants