Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type hints for rsast and sast files #1994

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Added type hints for rsast and sast files #1994

merged 6 commits into from
Aug 20, 2024

Conversation

aryanpola
Copy link
Contributor

What does this implement/fix? Explain your changes.

Added type hints for rsast and sast files under shapelet based collection transformation.

#1910

@aryanpola aryanpola requested a review from aiwalter as a code owner August 20, 2024 13:40
@aeon-actions-bot aeon-actions-bot bot added the transformations Transformations package label Aug 20, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@aryanpola
Copy link
Contributor Author

@baraline Can you let me know if there are changes to made?

Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks ! Just some minor changes and some not directly related to type hints but might as well adress them while we are at it.

Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again! 😄

@baraline baraline merged commit 62cbaff into aeon-toolkit:main Aug 20, 2024
14 checks passed
@aryanpola aryanpola deleted the rsast_sast branch August 20, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants