-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Type Hints for dilated shapelets #1910 #1941
Conversation
Thank you for contributing to
|
Could you please let me know the reasons for the failure of the tests? @aiwalter |
I recommend checking where the pytests failed. For example, I browsed some of the pytests and saw an error in the "compute_shapelete_dist_vector" method. "distanceCPUDispatcher" probably is an error? def compute_shapelet_dist_vector( |
Sorry I should have been tagged for this file, seems i'm not on maintainer list for this one. @aryanpola If you need any further help with the PR instead of closing it don't hesitate to ask me ! |
What does this implement/fix? Explain your changes.
I have added type hints for function variables and return values as described in issue #1910