Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Type Hints for dilated shapelets #1910 #1941

Closed
wants to merge 8 commits into from
Closed

Added Type Hints for dilated shapelets #1910 #1941

wants to merge 8 commits into from

Conversation

aryanpola
Copy link
Contributor

What does this implement/fix? Explain your changes.
I have added type hints for function variables and return values as described in issue #1910

@aryanpola aryanpola requested a review from aiwalter as a code owner August 10, 2024 14:33
@aeon-actions-bot aeon-actions-bot bot added the transformations Transformations package label Aug 10, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@aryanpola
Copy link
Contributor Author

Could you please let me know the reasons for the failure of the tests? @aiwalter

@Datadote
Copy link
Contributor

I recommend checking where the pytests failed. For example, I browsed some of the pytests and saw an error in the "compute_shapelete_dist_vector" method. "distanceCPUDispatcher" probably is an error?

def compute_shapelet_dist_vector(
X_subs: np.ndarray, values: np.ndarray, length: int, distanceCPUDispatcher
):

@aryanpola aryanpola marked this pull request as draft August 12, 2024 06:25
@aryanpola aryanpola closed this Aug 12, 2024
@baraline
Copy link
Member

baraline commented Aug 12, 2024

Sorry I should have been tagged for this file, seems i'm not on maintainer list for this one. @aryanpola If you need any further help with the PR instead of closing it don't hesitate to ask me !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants