Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Added Type Hints for _dilated_shapelet_transform #1949

Merged
merged 13 commits into from
Aug 17, 2024
Merged

[DOC] Added Type Hints for _dilated_shapelet_transform #1949

merged 13 commits into from
Aug 17, 2024

Conversation

aryanpola
Copy link
Contributor

What does this implement/fix? Explain your changes.
I have added type hints for function variables and return values as described in issue.
#1910

@aryanpola aryanpola requested a review from aiwalter as a code owner August 12, 2024 06:54
@aeon-actions-bot aeon-actions-bot bot added the transformations Transformations package label Aug 12, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst
Copy link
Member

Hi, I can take a look at this in a bit if you are still having issues. Feel free to @ me with any questions. @baraline left a comment on your previous PR so im sure he would be open to questions as well

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes required IMO, @baraline might have more for the later function hints

@MatthewMiddlehurst MatthewMiddlehurst added the documentation Improvements or additions to documentation label Aug 13, 2024
@MatthewMiddlehurst MatthewMiddlehurst changed the title Added Type Hints for _dilated_shapelet_transform [DOC] Added Type Hints for _dilated_shapelet_transform Aug 13, 2024
@aryanpola
Copy link
Contributor Author

@baraline Is there any reason for the tests to be canceled, they were all successful when I committed but got canceled when I updated the branch.

@baraline
Copy link
Member

I don't think that should be happening, let me check

Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-runned the test, maybe something went wrong with the CI pipeline ? Some small changes and we should be good to go !

@baraline
Copy link
Member

baraline commented Aug 13, 2024

Some changes were made to the file you are working with on #1959, which added two parameters to the _init_random_shapelet_params and random_dilated_shapelet_extraction function, which both are ndarray of integers. (need to merge main to see them). Edit : also to dilated_shapelet_transform, the shapelet tuple with have two additional ndarrays
Concerning the test, they seem to be canceling from time to time for yet unknown reasons, will keep an eye out and relaunch them if necessary.

@aryanpola
Copy link
Contributor Author

Some changes were made to the file you are working with on #1959, which added two parameters to the _init_random_shapelet_params and random_dilated_shapelet_extraction function, which both are ndarray of integers. (need to merge main to see them). Edit : also to dilated_shapelet_transform, the shapelet tuple with have two additional ndarrays Concerning the test, they seem to be canceling from time to time for yet unknown reasons, will keep an eye out and relaunch them if necessary.

Are there any changes that I am supposed to make?

@baraline
Copy link
Member

Yes, could you should first merge the main branch into this and had the type hints for the new parameters of the functions I listed ?

@aryanpola
Copy link
Contributor Author

Yes, could you should first merge the main branch into this and had the type hints for the new parameters of the functions I listed ?

Added the type hints after merging the main branch. Is there anything else to do?

@baraline
Copy link
Member

baraline commented Aug 13, 2024

Just need to resolve the remaining conversation, and we'll be good to go I think ! 😄
(One from Matthew still need an action from you)

Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me! Thanks for your patience! 😄

@aryanpola
Copy link
Contributor Author

Looking good to me! Thanks for your patience! 😄

Thanks a lot for the help!

@baraline baraline dismissed MatthewMiddlehurst’s stale review August 17, 2024 19:09

Changes have been adressed

@baraline baraline merged commit ce73b90 into aeon-toolkit:main Aug 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants