-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Added useful attributes to extracted shapelets for RDST #1959
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks ! Would be nice to have start index for all shapelets to visualize the generation process at some point
…o rdst_startpos
I can't seem to figure out how the error relates to the code I have added |
I dmed you about the issue, someone else had it previously and it seems its just a random chance to pass it or not. Worth raising it as an issue. Haven't looked at the algorithm myself yet but id assume it most likely needs to have set a seed. |
Just noting that there will be an impact on #1949 when this goes though, is it ready for review now ? |
yes please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the addition of classes, although it might not be obvious to use. For example, consider a shapelet extracted from class 0. It might be more discriminative toward class 2 due to the absence of a common pattern present in class 0 and 1 for example.
But this is not the concern of this PR, the storing of these attributes also not likely to take much space, so LGTM !
Yes I totally agree, that's exactly what made me want to use it in my notebook haha, being able to visualise shapelets and their source class should improve explainability |
Reference Issues/PRs
Fixes #1950
What does this implement/fix? Explain your changes.
Added a list of starting points & class values for the transformer's extracted shapelets.
Does your contribution introduce a new dependency? If yes, which one?
No.
Any other comments?
I'm pretty sure this introduction doesn't harm any functionality across the module. I searched for all uses of RDST and checked for calls to RDSTClassifier.transformer.shapelets