Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Move reset #1751

Closed
wants to merge 1 commit into from
Closed

[BUG] Move reset #1751

wants to merge 1 commit into from

Conversation

TonyBagnall
Copy link
Contributor

fixes #1750 with simplest solution

@TonyBagnall TonyBagnall added the transformations Transformations package label Jul 3, 2024
@TonyBagnall TonyBagnall requested a review from aiwalter as a code owner July 3, 2024 09:47
@aeon-actions-bot aeon-actions-bot bot added the bug Something isn't working label Jul 3, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ].
I would have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)

@MatthewMiddlehurst
Copy link
Member

MatthewMiddlehurst commented Jul 3, 2024

The metadata update should not really be happening in the first place. See #1479 which disables it.

@TonyBagnall
Copy link
Contributor Author

The metadata update should not really be happening in the first place. See #1479 which disables it.

dont actually agree with this, meta data storage should be possible when passed as kwargs to save time, useful with very large datasets, but Im ok to go with #1479 instead of this

@TonyBagnall TonyBagnall closed this Jul 3, 2024
@TonyBagnall TonyBagnall deleted the ajb/base_collection branch November 25, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CollectionTransformers with fit_is_empty is true
3 participants