Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add names to create steps_ in CollectionPipeline #1796

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

TonyBagnall
Copy link
Contributor

Fixes #1748
adds this to fit_transform to make sure the attribute in self.steps is stored in self.steps in (name,estimator) pairs, as is the convention it seems

    def _fit_transform(self, X, y=None) -> np.ndarray:
        self.steps_ = self._check_estimators(
            self._steps, attr_name="steps_", cls_type=SklearnBaseEstimator
        )
        Xt = X
        for i in range(len(self.steps_)):
            Xt = self.steps_[i][1].fit_transform(X=Xt)
        return Xt

@TonyBagnall TonyBagnall added the transformations Transformations package label Jul 14, 2024
@aeon-actions-bot aeon-actions-bot bot added the bug Something isn't working label Jul 14, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@TonyBagnall TonyBagnall changed the title [BUG]add names to create steps_ [BUG] Add names to create steps_ in CollectionPipeline Jul 14, 2024
@TonyBagnall TonyBagnall merged commit 909a035 into main Jul 16, 2024
15 checks passed
@TonyBagnall TonyBagnall deleted the ajb/collection_transform branch July 16, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CollectionTransformerPipeline fit_transform doesnt fit
2 participants