Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Documentation fixes and function changes for BaseCollectionEstimator #1864

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

MatthewMiddlehurst
Copy link
Member

What does this implement/fix? Explain your changes.

  • changes conversion function to return immediately if the input datatype is already in X_inner_type
  • updates unequal length metadata to store None for unequal length data
  • updates documentation for metadata and to match changes

@aeon-actions-bot aeon-actions-bot bot added the enhancement New feature, improvement request or other non-bug code enhancement label Jul 29, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst MatthewMiddlehurst changed the title [ENH] Documentation fixes and function changees for BaseCollectionEstimator [ENH] Documentation fixes and function changes for BaseCollectionEstimator Jul 29, 2024
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review July 30, 2024 20:56
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatthewMiddlehurst MatthewMiddlehurst merged commit af86767 into main Aug 2, 2024
14 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the mm/base-collection-tidy branch August 2, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants