-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Added useful class attributes to SAST based transforms #2006
Conversation
Thank you for contributing to
|
Hi Ivan, while memory wise the storage of these parameters would likely not cause too much trouble, I feel like this kind of optional storage should be gated behind a boolean given during initialization (something like I don't know if that's the goal of the PR (if not ignore it), but preferably, all the different shapelets methods should have the same name for these arguments, so we can use a common interface while inspecting them. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I don't think having these extra private variables will cause confusion for users, I think it is more straight forward having them there for accessibility rather than providing the option for storing them. More than happy to implement your idea though if you disagree. Maybe @MatthewMiddlehurst might have a preference?
Great point, I modified the start point variable name to be consistent with the other transforms! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given it's private I don't think theres a harm in adding it assuming the memory footprint is not large.
I agree we should eventually unify this between the approaches if possible. Not sure how they all do it differently, I think STC is a list of lists for each shapelet.
Happy to remove the function if it is mostly duplicated by the new visualisation tools.
Reference Issues/PRs
Fixes #2004
What does this implement/fix? Explain your changes.
Added class attributes found in ST that are helpful for interpreting shapelets. They do not serve functionality for the classifier but improve explainability.
Implemented:
The class each subseries is from,
the index of the original series the subseries is extracted from,
the start pos of the subseries in the original series.