[ENH] extending PR #2017 to multiclass case #2026
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See also #2016
What does this implement/fix? Explain your changes.
This is extending the previous PR which missed out the multiclass case for linear classifiers, here an distance is made inversely correlated to distance and for RDST the other two features are kept positively correlated.
Any other comments?
@baraline noticed that I missed the multiclass correction and explained that coefs are one vs all for this usecase so just need to grab the class coefs and manipulate them appropriately.
This is a fresh PR resolving merge conflicts which were present in PR 2018.