-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Added tags for clustering #2041
Conversation
Thank you for contributing to
|
thanks for this, but it not what quite what I meant. If you look at classification, we have a tag on the type of algorithm, e.g "algorithm_type": "distance" or "algorithm_type": "deeplearning", this is the only tag we want adding, not all the constructor arguments. |
@TonyBagnall I've made changes, please let me know if there's more to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this, minor things
- could you change KShape to just "distance"
- You do not need to repeat the tag for classes that inherit from KMedoids, you can just remove them for CLARANS and CLARA
@all-contributors add @aryanpola for code |
I've put up a pull request to add @aryanpola! 🎉 |
I've changed them. Thanks for the help😊 |
thanks for this |
What does this implement/fix? Explain your changes.
I've added the necessary tags for some files under clustering.
#2035