Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Added tags for clustering #2041

Merged
merged 7 commits into from
Sep 12, 2024
Merged

[ENH] Added tags for clustering #2041

merged 7 commits into from
Sep 12, 2024

Conversation

aryanpola
Copy link
Contributor

What does this implement/fix? Explain your changes.
I've added the necessary tags for some files under clustering.
#2035

@aeon-actions-bot aeon-actions-bot bot added the clustering Clustering package label Sep 8, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#4011F3}{\textsf{clustering}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@TonyBagnall
Copy link
Contributor

thanks for this, but it not what quite what I meant. If you look at classification, we have a tag on the type of algorithm, e.g

"algorithm_type": "distance"

or

"algorithm_type": "deeplearning",

this is the only tag we want adding, not all the constructor arguments.

@aryanpola
Copy link
Contributor Author

thanks for this, but it not what quite what I meant. If you look at classification, we have a tag on the type of algorithm, e.g

"algorithm_type": "distance"

or

"algorithm_type": "deeplearning",

this is the only tag we want adding, not all the constructor arguments.

@TonyBagnall I've made changes, please let me know if there's more to do.

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this, minor things

  1. could you change KShape to just "distance"
  2. You do not need to repeat the tag for classes that inherit from KMedoids, you can just remove them for CLARANS and CLARA

@TonyBagnall
Copy link
Contributor

@all-contributors add @aryanpola for code

Copy link
Contributor

@TonyBagnall

I've put up a pull request to add @aryanpola! 🎉

@aryanpola
Copy link
Contributor Author

thanks for this, minor things

  1. could you change KShape to just "distance"
  2. You do not need to repeat the tag for classes that inherit from KMedoids, you can just remove them for CLARANS and CLARA

I've changed them. Thanks for the help😊

@TonyBagnall
Copy link
Contributor

thanks for this

@TonyBagnall TonyBagnall merged commit d97f790 into aeon-toolkit:main Sep 12, 2024
14 checks passed
@aryanpola aryanpola deleted the algorithm_type branch September 12, 2024 06:59
@MatthewMiddlehurst MatthewMiddlehurst added the enhancement New feature, improvement request or other non-bug code enhancement label Sep 16, 2024
@MatthewMiddlehurst MatthewMiddlehurst changed the title Added tags for clustering [ENH] Added tags for clustering Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clustering Clustering package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants