-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Documentation improvement of BaseDeepClassifier and BaseCollectionEstimator #2516
Conversation
Thank you for contributing to
|
This seems better to me. Any thoughts @lucifer4073 as you opened the issue? |
This PR looks good. It would be beneficial to address the documentation for other base classes that currently lack it, potentially in a separate PR.. |
@lucifer4073 @MatthewMiddlehurst I’d be happy to address this issue for the other base classes as well. If it’s alright with you, may I proceed with creating a PR for those once this current one is merged? |
Hi @lucifer4073 @MatthewMiddlehurst, Just checking if it’s alright for me to work on a PR for the other base classes once this one is merged. Would appreciate your confirmation whenever you get a chance! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks !
It would be nice to have such docs for the other base class indeed ! I think you can go ahead @kevinzb56 and create PRs for those too if you want.
@baraline thank you so much! I'll make the other PRs too. |
@all-contributors please add @kevinzb56 for code |
I've put up a pull request to add @kevinzb56! 🎉 |
@all-contributors please add @kevinzb56 for docs |
I've put up a pull request to add @kevinzb56! 🎉 |
@all-contributors please add @kevinzb56 for docs |
I've put up a pull request to add @kevinzb56! 🎉 |
Reference Issues/PRs
Solves #2509
What does this implement/fix? Explain your changes.
This PR adds comprehensive documentation for the BaseCollectionEstimator class in the aeon library. The documentation follows the established format used for other base classes (e.g., BaseClassifier) and includes:
A clear description of the class's purpose and functionality.
A list of defining methods, grouped into logical categories (preprocessing, input checking, input conversion, and shape checking).
Inherited inspection methods and state attributes.
Additional context about the class's role in the library.
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access