Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bug resolved in Aeabgru for temporal_latent_space=True #2566

Closed
wants to merge 2 commits into from

Conversation

lucifer4073
Copy link
Contributor

Reference Issues/PRs

Fixes #2560

What does this implement/fix? Explain your changes.

The given PR resolved the error thrown in AEAttentionBiGRUNetwork when temporal_latent_space was set to True.

Does your contribution introduce a new dependency? If yes, which one?

No

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator/function to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@aeon-actions-bot aeon-actions-bot bot added bug Something isn't working networks Networks package labels Feb 23, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#379E11}{\textsf{networks}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this, but the actual fix should be:

x = tf.keras.layers.Conv1D(filters=self.latent_space_dim, kernel_size=1)(x)
shape_before_flatten = x.shape[1:]

and not:

shape_before_flatten = x.shape[1:]
x = tf.keras.layers.Conv1D(filters=self.latent_space_dim, kernel_size=1)(x)

to take the last shape of the encoder not the previous one.

Could you close this PR and do the fix on the PR where you added the test ? it will just make it less confusing to review.

@lucifer4073
Copy link
Contributor Author

Hi @hadifawaz1999,

Thanks for the response. I will close this PR and make the changed accordinly in #2540.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working networks Networks package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] UnboundLocalError in AEAttentionBiGRUNetwork When temporal_latent_space=True
2 participants