-
Notifications
You must be signed in to change notification settings - Fork 209
[ENH]Type hints for primitive data types in base module #2736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR includes many unrelated changes (see examples below), which would break a lot of our automation and code! Please clean up this PR by syncing your repository and rebasing the changes from this PR.
}, | ||
{ | ||
"login": "HaroonAzamFiza", | ||
"name": "HaroonAzamFiza", | ||
"avatar_url": "https://avatars.githubusercontent.com/u/183639840?v=4", | ||
"profile": "https://github.com/HaroonAzamFiza", | ||
"contributions": [ | ||
"doc" | ||
] | ||
}, | ||
{ | ||
"login": "Ramana-Raja", | ||
"name": "Ramana Raja", | ||
"avatar_url": "https://avatars.githubusercontent.com/u/83065061?v=4", | ||
"profile": "https://github.com/Ramana-Raja", | ||
"contributions": [ | ||
"code" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example 1
python_version: | ||
description: "Python version used" | ||
required: false | ||
default: "3.11" | ||
additional_extras: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example 2
- name: Setup Python 3.11 | ||
uses: actions/setup-python@v5 | ||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: "3.11" | ||
python-version: "3.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example 3
Reference Issues/PRs
Fixes #1454 some part
What does this implement/fix? Explain your changes.
I have added some type hints for primitive data types and strings for the base module
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
No
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access