Skip to content

[BUG] Fix RDST admissible sampling point method #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

baraline
Copy link
Member

Reference Issues/PRs

Fixes #2759

What does this implement/fix? Explain your changes.

Fix shapelet sampling point method returning the id of the choice, and not the timestamp linked to the id of the choice.

Any other comments?

See #2759 for performance comparison.

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

@baraline baraline linked an issue Apr 26, 2025 that may be closed by this pull request
@aeon-actions-bot aeon-actions-bot bot added bug Something isn't working transformations Transformations package labels Apr 26, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@baraline baraline added transformations Transformations package and removed transformations Transformations package labels Apr 26, 2025
@baraline
Copy link
Member Author

Expected results seem to differ for some test configurations, not sure why yet

@MatthewMiddlehurst
Copy link
Member

Happy to review when its resolved.

@baraline
Copy link
Member Author

baraline commented May 1, 2025

I'm currently clueless about why these fails, I cannot seem to reproduce the issue on my Ubuntu either ...
If anyone has any leads, I'd be grateful, otherwise i'll come back to this to do some bug hunting later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] RDST admissible sampling point method returns wrong index
2 participants