Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V7.7.1 #437

Merged
merged 2 commits into from
Dec 20, 2024
Merged

V7.7.1 #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ce018f
roster apply fix error handling
Dec 20, 2024
23b103c
AGI: Add `device` filter in namespace view.
Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG/7.7.1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@ _Release Date: December 16th, 2024_
* Update required go version in expiry systems to `v1.23`.
* AGI: Fix patterns to handle connector excessive logging on some errors.
* AGI: Fix restarting log ingest and installation of the `erro` command.
* Fix: The `roster apply` command would not handle problematic nodes.
* AGI: Add `device` filter in namespace view.
8 changes: 7 additions & 1 deletion src/cmdRosterApply.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ type rosterNodes struct {
func (c *rosterApplyCmd) findNodes(n int) *rosterNodes {
out, err := b.RunCommands(string(c.ClusterName), [][]string{{"asinfo", "-v", "roster:namespace=" + c.Namespace}}, []int{n})
if err != nil {
log.Printf("ERROR skipping node, running asinfo on node %d: %s", n, err)
if len(out) == 0 {
out = [][]byte{{'-'}}
}
log.Printf("ERROR skipping node, running asinfo on node %d: %s: %s", n, err, string(out[0]))
return nil
}
observedNodesSplit := strings.Split(strings.Trim(string(out[0]), "\t\r\n "), ":observed_nodes=")
Expand Down Expand Up @@ -142,6 +145,9 @@ func (c *rosterApplyCmd) runApply() error {
if len(observedNodes) > 0 {
close(observedNodes)
for ona := range observedNodes {
if ona == nil {
continue
}
if ona.replicationFactor > rf {
rf = ona.replicationFactor
}
Expand Down
Loading