Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for agda 2.6.4.1 #1083

Merged
merged 15 commits into from
Feb 12, 2024
Merged

Release for agda 2.6.4.1 #1083

merged 15 commits into from
Feb 12, 2024

Conversation

felixwellen
Copy link
Collaborator

The suggested heap size also seems to set a maximum. I don't why we have a suggested heap size anyway, so I just removed that, since make failed with agda 2.6.4.1, compiled with ghc 9.8.1.

The suggested heap size also seems to set a maximum.
I don't why we have a suggested heap size anyway, so I just removed that, since make failed with agda 2.6.4.1, compiled with ghc 9.8.1.
@felixwellen felixwellen marked this pull request as ready for review January 22, 2024 11:02
@felixwellen
Copy link
Collaborator Author

I think we should stick to removing the line RTS_OPTIONS=+RTS -H6G -RTS, since it causes problems with newer ghc versions (than we are using in the CI - that's why it didn't show here).
Can someone (@phijor @jpoiret ?) check the flake and do nix flake update and commit the result?

@felixwellen felixwellen marked this pull request as draft January 22, 2024 11:16
@phijor
Copy link
Contributor

phijor commented Jan 22, 2024

I've updated the flake inputs locally; I'll get back to you with the result once it's finished building.

NB: I'm not a contributor to the repo, so I cannot directly push to this branch. I can put the commit in a fork of mine though.

@felixwellen
Copy link
Collaborator Author

Thanks!

@felixwellen
Copy link
Collaborator Author

NB: I'm not a contributor to the repo, so I cannot directly push to this branch. I can put the commit in a fork of mine though.

Yes, just do that and I'll drag it over here.

@jpoiret
Copy link
Contributor

jpoiret commented Jan 22, 2024

I don't use/have Nix, so I can't really help with flakes, but I'm doing my best keeping it updated on Guix!

@phijor
Copy link
Contributor

phijor commented Jan 22, 2024

I updated the flake inputs, everything builds successfully. Changes should be available as a commit here (plain-text patch here).

@felixwellen felixwellen marked this pull request as ready for review January 23, 2024 10:23
@felixwellen
Copy link
Collaborator Author

Looks all good to me now!

@felixwellen
Copy link
Collaborator Author

@mortberg @mzeuner @ecavallo are you okay with a release or should I wait for anything with merging this? If you have the time, maybe it is good to test it on your machine, since there was some trouble with the make file - I noticed some weird behaviour around RTS options with newer GHC versions.

@felixwellen
Copy link
Collaborator Author

I actually missed one instance of "Experiments"-exclusion in the makefile - maybe this went by the CI because of caching...

@felixwellen
Copy link
Collaborator Author

It is fixed, looks all good to me now (I checked 977 files in 25 min, so there is also no tc-time blow up).

@felixwellen
Copy link
Collaborator Author

I assume no complaints means I can go ahead with merging this and doing all the release stuff (agda 2.6.4.2 is around the corner..).

@felixwellen
Copy link
Collaborator Author

On one of my machines, there is somehow a too low default maximum for the heap. Setting a high maximum (I chose 32G) solves that and I don't see any harm in that, so I'll leave that in as it is now.

@felixwellen felixwellen merged commit d69d74c into master Feb 12, 2024
1 check passed
@felixwellen felixwellen deleted the release-for-2.6.4.1 branch February 15, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants