-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release for agda 2.6.4.1 #1083
Release for agda 2.6.4.1 #1083
Conversation
The suggested heap size also seems to set a maximum. I don't why we have a suggested heap size anyway, so I just removed that, since make failed with agda 2.6.4.1, compiled with ghc 9.8.1.
3195827
to
1620999
Compare
I've updated the flake inputs locally; I'll get back to you with the result once it's finished building. NB: I'm not a contributor to the repo, so I cannot directly push to this branch. I can put the commit in a fork of mine though. |
Thanks! |
Yes, just do that and I'll drag it over here. |
I don't use/have Nix, so I can't really help with flakes, but I'm doing my best keeping it updated on Guix! |
Looks all good to me now! |
The suggested heap size also seems to set a maximum. I don't why we have a suggested heap size anyway, so I just removed that, since make failed with agda 2.6.4.1, compiled with ghc 9.8.1.
…n/release-for-2.6.4.1
011dc30
to
981766e
Compare
I actually missed one instance of "Experiments"-exclusion in the makefile - maybe this went by the CI because of caching... |
It is fixed, looks all good to me now (I checked 977 files in 25 min, so there is also no tc-time blow up). |
I assume no complaints means I can go ahead with merging this and doing all the release stuff (agda 2.6.4.2 is around the corner..). |
On one of my machines, there is somehow a too low default maximum for the heap. Setting a high maximum (I chose 32G) solves that and I don't see any harm in that, so I'll leave that in as it is now. |
The suggested heap size also seems to set a maximum. I don't why we have a suggested heap size anyway, so I just removed that, since make failed with agda 2.6.4.1, compiled with ghc 9.8.1.