Decouple AgentManager from serialization
#325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of accepting a serialized HostNetworkGroup, the AgentManager trait now takes a HostNetworkGroup directly, allowing the review-protocol crate to handle serialization.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=======================================
Coverage 67.63% 67.64%
=======================================
Files 67 67
Lines 13203 13200 -3
=======================================
- Hits 8930 8929 -1
+ Misses 4273 4271 -2 ☔ View full report in Codecov by Sentry. |
sophie-cluml
approved these changes
Oct 8, 2024
sehkone
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the methods in
AgentManagertrait to acceptHostNetworkGroupdirectly instead of its serialized form. By doing so, we allow the review-protocol crate to handle serialization, which is a more suitable place for this responsibility.This change is required for petabi/review-protocol#13.