Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify tags in decorator #57

Merged
merged 9 commits into from
Dec 13, 2024

Conversation

diasdm
Copy link
Contributor

@diasdm diasdm commented Dec 10, 2024

What do these changes do?

Allow to specify tags in the decorator:

@SCHEMA.api(tags=["UseCase"])

Are there changes in behavior for the user?

If tags is not specified the behavior is the same, when it is the paths will be grouped

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

If there's interest I don't mind adding tests add documentation

aiohttp_apischema/generator.py Outdated Show resolved Hide resolved
aiohttp_apischema/generator.py Show resolved Hide resolved
aiohttp_apischema/generator.py Outdated Show resolved Hide resolved
aiohttp_apischema/generator.py Show resolved Hide resolved
aiohttp_apischema/generator.py Show resolved Hide resolved
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.86%. Comparing base (7751c9f) to head (0a3b58b).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   96.70%   96.86%   +0.15%     
==========================================
  Files           5        5              
  Lines         395      415      +20     
  Branches       56       37      -19     
==========================================
+ Hits          382      402      +20     
  Misses          5        5              
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

diasdm and others added 2 commits December 13, 2024 10:11
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
@diasdm
Copy link
Contributor Author

diasdm commented Dec 13, 2024

I think the last commit matches the requested changes, let me know if it fits

@diasdm diasdm requested a review from Dreamsorcerer December 13, 2024 16:16
@Dreamsorcerer Dreamsorcerer merged commit 463621f into aio-libs:master Dec 13, 2024
20 checks passed
@Dreamsorcerer
Copy link
Member

Thanks a lot for that.

@Dreamsorcerer
Copy link
Member

Forgot the docs. If you have a moment to send a followup PR to add the parameter to the docs, that'd be great.

@diasdm diasdm mentioned this pull request Dec 16, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants