Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 CDK: Fix DNS resolution error handling #359

Closed

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Fix DNS resolution error handling in CDK to properly handle temporary DNS failures.

Fixes: airbytehq/airbyte-internal-issues#11320

Changes:

  • Update default error mapping to treat InvalidURL as transient error
  • Add unit tests for DNS error handling
  • Remove need for custom error handlers in connectors

Current Implementation:
Both Klaviyo and LinkedIn Ads connectors implement custom error handlers for DNS resolution issues:

This change centralizes that handling in the CDK to ensure consistent behavior across all connectors.

Link to Devin run: https://app.devin.ai/sessions/6b54ed98f6e84226b1f5a7cb2d1a941d

Requested by: AJ (@aaronsteers)

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Copy link
Contributor Author

🤖 Devin AI Engineer

Original prompt from Aaron:

Received message in Slack channel #ask-devin-ai:

@Devin - Can you help me get started on this issue? <https://github.com/airbytehq/airbyte-internal-issues/issues/11320>

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration bot and others added 12 commits February 20, 2025 19:58
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Copy link
Contributor Author

Closing in favor of #360 which takes a better approach by introducing DNSResolutionError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants