Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix submit workflow #35

Merged
merged 2 commits into from
Oct 19, 2024
Merged

ci: Fix submit workflow #35

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
095142b
ci: Fix submit workflow
Semro Oct 16, 2024
21458f2
Revert release change, add step for uploading assets
aklinker1 Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/submit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ jobs:
with:
path: .output/*.zip
if-no-files-found: error
include-hidden-files: true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, haven't used this since this action started ignoring hidden files. Thanks!


- name: Submit
run: |
Expand Down Expand Up @@ -88,4 +89,6 @@ jobs:

- name: Release
if: ${{ !inputs.dryRun }}
run: pnpx changelogen@latest gh release ${{ steps.version.outputs.newVersion }} --token ${{ github.token }}
run: gh release create v${{ steps.version.outputs.newVersion }} .output/*.zip -F CHANGELOG.md
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelogen gh release just syncs the changelog with the latest release, it doesn't regenerate the changelog or anything like that. So these are doing almost the same thing.

The -F CHANGELOG.md is using your entire changelog as your release notes... Which I don't think you want?

I don't know why github.token worked for me and not for you, weird. You can replace it with secrets.GITHUB_TOKEN like you did, that's fine.

And uploading the zip files as artifacts would be a good idea...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was confused with changelogen gh release command, not realizing it's a subcommand of changelogen package. So, it might be working correctly.