Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more types #4

Merged
merged 3 commits into from
May 16, 2024
Merged

Add more types #4

merged 3 commits into from
May 16, 2024

Conversation

ternaus
Copy link
Contributor

@ternaus ternaus commented May 16, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.33333% with 56 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@3d9059f). Click here to learn what that means.

Files Patch % Lines
benchmark/benchmark.py 0.00% 43 Missing ⚠️
benchmark/utils.py 0.00% 11 Missing ⚠️
albucore/functions.py 94.44% 1 Missing ⚠️
albucore/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage        ?   23.71%           
=======================================
  Files           ?        7           
  Lines           ?      371           
  Branches        ?        0           
=======================================
  Hits            ?       88           
  Misses          ?      283           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 4 issues found
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

benchmark/benchmark.py Outdated Show resolved Hide resolved
benchmark/benchmark.py Show resolved Hide resolved
benchmark/benchmark.py Show resolved Hide resolved
benchmark/benchmark.py Show resolved Hide resolved
albucore/functions.py Show resolved Hide resolved
benchmark/benchmark.py Show resolved Hide resolved
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@ternaus ternaus merged commit 6e65f7b into main May 16, 2024
16 checks passed
@ternaus ternaus deleted the add_more_types branch May 16, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants