Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eip-7702 ui demo #1302

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: eip-7702 ui demo #1302

wants to merge 9 commits into from

Conversation

adamegyed
Copy link
Collaborator

@adamegyed adamegyed commented Jan 28, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on significant updates to the examples/ui-demo project, including the addition of new smart contract functionalities, enhancements to user connection handling, and various UI component improvements.

Detailed summary

  • Removed multiple mint-card components.
  • Added Counter and NFT smart contracts.
  • Introduced useMint7702 and useMintDefault hooks.
  • Updated UserConnectionDetails to support wallet type.
  • Enhanced WalletTypeSwitch for better UI interaction.
  • Configured new transport setups for Odyssey.
  • Updated package dependencies and configurations.

The following files were skipped due to too many changes: examples/ui-demo/src/components/user-connection-avatar/RenderUserConnectionAvatar.tsx, examples/ui-demo/src/hooks/useRecurringTransactions.ts, examples/ui-demo/contracts/broadcast/DeployNFT.s.sol/911867/run-1736807829.json, examples/ui-demo/contracts/pnpm-lock.yaml, examples/ui-demo/contracts/broadcast/DeploySwapVenue.s.sol/911867/run-1736537366.json

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 1:47am
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 10 unresolved Feb 12, 2025 1:47am

Copy link
Member

@jakehobbs jakehobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on the preview link & everything seems solid! left a couple of minor comments, but they are pretty nit-picky.

{/* <HelpTooltip text="An account powered by a smart contract to enable more features. Not an EOA. Recommended for new wallets." /> */}
</div>
<WalletTypeSwitch
id="theme-switch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ i think this was copied from the ThemeSwitch and would result in 2 elements on the page w/ the same id

Comment on lines 33 to 35
className="mb-4 rounded-xl object-cover h-[222px] w-[326px]"
width={326}
height={222}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ nit: any reason for setting height & width via both tailwind as well as the Image props?

Comment on lines 66 to 70
background:
"linear-gradient(132deg, #FF9C27 0%, #FD48CE 100%)",
WebkitBackgroundClip: "text",
backgroundClip: "text",
WebkitTextFillColor: "transparent",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈 doesn't really matter, but tailwind has support for this: https://tailwindcss.com/docs/background-clip

/>
<Stage
icon={status.batch}
description="Deploying your smart account..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a little weird to me that it keeps the "deploying your smart account" stage whenever a user performs the "re-collect nft" action (when in reality that would only happen the first time they mint)... but probably not the biggest deal if it's a pain to change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good callout, you could create another MintStatus value and track if it's the first time minting in useMint with a useState var

adamegyed and others added 8 commits February 10, 2025 17:14
feat: update 7702 mint flow to actually use 7702

feat: partial recurring transfer support

feat: ui progress

feat: react state management

feat: add permission hooks to session key

fix: add templates to demo build

fix: declare env var in turbo

feat: ui demo user card reflects 7702 delegation status (#1294)

* feat: have user avatar reflect if account has been delegated

* feat: reflects delegation status in user details card

* fix: forces delegation status query to refetch until available

* chore: updates comment

* refactor: uses viem public client and refetches delegation addr when nftTransferred status changes

* refactor: uses defined url constant

* chore: removes unnecessary check

fix: coalesce undefined code result

fix: forces delegation query to refetch until available

feat: updated 7702 info blurb

chore: cleanup
* feat: responsive transaction card

* feat: responsive cards
* feat: mav2 in ui demo

* chore: move files back

* chore: rename MAv2 client hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants