feat: cleanup uo interface to be safer to modifications

alchemyplatform · Feb 14, 2025 · 7701bf9 · 7701bf9
1 parent fdfb2f3
commit 7701bf9
Show file tree

Hide file tree

Showing 26 changed files with 1,103 additions and 799 deletions.
diff --git a/Makefile b/Makefile
@@ -2,7 +2,7 @@
 
 ##@ Test
 
-UNIT_TEST_ARGS := --locked --workspace --all-features
+UNIT_TEST_ARGS := --locked --workspace --all-features --no-fail-fast
 PROFILE ?= release
 DOCKER_IMAGE_NAME ?= alchemyplatform/rundler
 BIN_DIR = "dist/bin"

diff --git a/crates/aggregators/pbh/src/pbh.rs b/crates/aggregators/pbh/src/pbh.rs
@@ -21,7 +21,7 @@ use rundler_types::{
         AggregatorCosts, SignatureAggregator, SignatureAggregatorError, SignatureAggregatorResult,
     },
     v0_7::UserOperation,
-    UserOperationVariant,
+    UserOperation as _, UserOperationVariant,
 };
 
 sol! {
@@ -117,17 +117,17 @@ where
             }
             let uo: UserOperation = user_op.clone().into();
 
-            if uo.signature.len() < PBH_PROOF_LENGTH {
+            if uo.signature().len() < PBH_PROOF_LENGTH {
                 return Err(SignatureAggregatorError::InvalidUserOperation(format!(
                     "User operation signature is not the correct length: {} < {}",
-                    uo.signature.len(),
+                    uo.signature().len(),
                     PBH_PROOF_LENGTH
                 )));
             }
 
-            let proof_start = uo.signature.len() - PBH_PROOF_LENGTH;
+            let proof_start = uo.signature().len() - PBH_PROOF_LENGTH;
             agg_proofs.push(
-                PBHPayload::abi_decode(&uo.signature[proof_start..], true).map_err(|e| {
+                PBHPayload::abi_decode(&uo.signature()[proof_start..], true).map_err(|e| {
                     SignatureAggregatorError::InvalidUserOperation(format!(
                         "Malformed PBH proof: {}",
                         e