Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(builder): add more builder metrics for latency tracking #1016

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat(builder): add more builder metrics for latency tracking #1016

merged 1 commit into from
Feb 13, 2025
+77 −27

Conversation

dancoombs
Copy link
Collaborator

Closes #1012

dancoombs
dancoombs commented Feb 13, 2025
View reviewed changes
crates/builder/src/bundle_sender.rs
@@ -1258,8 +1272,8 @@ struct BuilderMetric {
cancellation_txns_failed: Counter,
#[metric(describe = "the count of state machine errors.")]
state_machine_errors: Counter,
#[metric(describe = "the timespan a bundle is build.")]
bundle_build_time_ms: Histogram,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was duplicated in bundle_proposer

@codecov Codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.50000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 59.21%. Comparing base (c591112) to head (1a9111b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/builder/src/transaction_tracker.rs 32.00% 17 Missing ⚠️
crates/builder/src/bundle_sender.rs 86.20% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/builder/src/bundle_proposer.rs 92.56% <100.00%> (+<0.01%) ⬆️
crates/builder/src/bundle_sender.rs 73.54% <86.20%> (-0.03%) ⬇️
crates/builder/src/transaction_tracker.rs 72.31% <32.00%> (-2.11%) ⬇️
Flag Coverage Δ
unit-tests 59.21% <62.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 66.50% <62.50%> (-0.16%) ⬇️
dev ∅ <ø> (∅)
pool 67.71% <ø> (ø)
provider 18.99% <ø> (ø)
rpc 26.51% <ø> (ø)
sim 77.59% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.97% <ø> (ø)
utils 32.43% <ø> (ø)

0xfourzerofour
0xfourzerofour previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

andysim3d
andysim3d previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@andysim3d andysim3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment

@dancoombs dancoombs dismissed stale reviews from andysim3d and 0xfourzerofour via 1a9111b February 13, 2025 17:14
@dancoombs dancoombs force-pushed the danc/more-builder-metrics branch from e980b64 to 1a9111b Compare February 13, 2025 17:14
@dancoombs dancoombs merged commit fdfb2f3 into main Feb 13, 2025
10 checks passed
@dancoombs dancoombs deleted the danc/more-builder-metrics branch February 13, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysim3d andysim3d andysim3d approved these changes

@0xfourzerofour 0xfourzerofour 0xfourzerofour left review comments

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[builder] Add more latency metrics to the builder
3 participants
@dancoombs @andysim3d @0xfourzerofour