Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rust 1.85, add unused crate deps lint, update dotenv #1032

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • Update rust to 1.85 and fix new lints
  • Add unused_crate_dependencies and remove all unused deps
  • Update dotenv to dotenvy due to this security recommendation
  • Update version to v0.6.0

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.59%. Comparing base (e96738d) to head (9f9c058).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/provider/src/alloy/provider_timeout.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
bin/rundler/src/main.rs 0.00% <ø> (ø)
crates/bindings/fastlz/src/lib.rs 0.00% <ø> (ø)
crates/builder/src/bundle_proposer.rs 92.91% <100.00%> (ø)
crates/contracts/src/v0_6.rs 91.48% <ø> (ø)
crates/contracts/src/v0_7.rs 97.33% <ø> (ø)
crates/pool/src/mempool/uo_pool.rs 93.34% <ø> (-0.01%) ⬇️
crates/provider/src/lib.rs 33.33% <ø> (ø)
crates/provider/src/alloy/provider_timeout.rs 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
unit-tests 59.59% <60.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 67.65% <100.00%> (+0.01%) ⬆️
dev ∅ <ø> (∅)
pool 68.13% <ø> (-0.01%) ⬇️
provider 19.48% <0.00%> (+0.01%) ⬆️
rpc 26.93% <ø> (+0.06%) ⬆️
sim 78.23% <ø> (+0.01%) ⬆️
tasks ∅ <ø> (∅)
types 66.82% <ø> (+0.01%) ⬆️
utils 32.43% <ø> (ø)

@@ -14,7 +14,7 @@ deny = [
[bans.workspace-dependencies]
duplicates = 'deny'
include-path-dependencies = true
unused = 'deny'
unused = 'allow'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something broke in cargo deny with rust 1.85 - it marked all of our workspace dependencies as unused - disabling this for now.

@dancoombs dancoombs merged commit c8e084e into main Feb 24, 2025
11 checks passed
@dancoombs dancoombs deleted the danc/rust-1.85 branch February 24, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants