Skip to content

Commit

Permalink
A0-4278: Support for finality-version in FE engine (#1727)
Browse files Browse the repository at this point in the history
# Description

This is 1/3 PR to make finality version available to FE engine.

## Type of change

Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)

# Checklist:

Nightly updatenet test from Testnet to main pass:
https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9173288151/job/25221938492
  • Loading branch information
Marcin-Radecki authored May 21, 2024
1 parent 5c4726e commit 8c45ee1
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
11 changes: 10 additions & 1 deletion .github/workflows/featurenet-create.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ on:
type: string
required: false
default: '5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY'
finality-version:
description: 'Finality version to start FE with. If specified, it must be a cardinal number.
If not specified, it will be generated from the runtime.'
type: string
required: false
workflow_call:
inputs:
featurenet-name:
Expand Down Expand Up @@ -77,7 +82,10 @@ on:
type: string
required: false
default: '5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY'

finality-version:
description: 'Finality version to start FE with. Must be a cardinal number'
type: string
required: false
jobs:
validate-inputs:
name: Validate inputs
Expand Down Expand Up @@ -191,3 +199,4 @@ jobs:
internal: ${{ inputs.internal && true || false }}
delete-first: true
sudo-account-id: ${{ inputs.sudo-account-id }}
finality-version: ${{ inputs.finality-version }}
1 change: 1 addition & 0 deletions .github/workflows/nightly-update-test-mainnet-testnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
validators: '7'
internal: true
short-session: false
finality-version: '3'

update-featurenet-to-testnet:
needs: [create-featurenet-from-mainnet]
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/nightly-update-test-testnet-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
validators: '8'
internal: true
short-session: false
finality-version: '3'

update-featurenet-to-main:
needs: [create-featurenet-from-testnet]
Expand Down

0 comments on commit 8c45ee1

Please sign in to comment.