Fix alephium/alephium-web3#489 - Unit tests fail for map inside subcontract #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 23, 2025 14:38
- Added new MapTestSub contract with init function for creating subcontracts. - Updated .project.json to include new source code hashes for MapTest and its related functions. - Created MapTestSub TypeScript definitions and JSON artifacts for integration. - Updated index.ts to export MapTestSub. - Added unit tests for MapTestSub initialization and state verification.
- Adjusted expected source file count from 61 to 62 in the contract loading test. - Updated assertions for source file types to match the new structure.
|
Hey @kwiscion, thank you so much for your fix ❤️ I’ve created a new branch based on yours and added a few commits. If you’d like, feel free to cherry-pick those commits into your branch, or I can open a new PR to include them for further review. |
|
@Lbqds thanks! I added your changes here |
|
Hey @kwiscion , this fix is included in release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extractMapsFromApiResultto consider all contracts for maps