Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhook): Only allow Elasticsearch datastore type for advancedVisibility on clusters => 1.21 #620

Merged
merged 1 commit into from
Jan 21, 2024
Merged

feat(webhook): Only allow Elasticsearch datastore type for advancedVisibility on clusters => 1.21 #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions api/v1beta1/temporalcluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ const (
// DatastoreSpec contains temporal datastore specifications.
type DatastoreSpec struct {
// Name is the name of the datastore.
// It should be unique and will be referenced within the persitence spec.
// It should be unique and will be referenced within the persistence spec.
// Defaults to "default" for default sore, "visibility" for visibility store,
// "secondaryVisibility" for secondary visibility store and
// "advancedVisibility" for advanced visibility store.
Expand Down Expand Up @@ -476,7 +476,7 @@ type TemporalPersistenceSpec struct {
// Feature only available for clusters >= 1.21.0.
// +optional
SecondaryVisibilityStore *DatastoreSpec `json:"secondaryVisibilityStore,omitempty"`
// AdvancedVisibilityStore holds the avanced visibility datastore specs.
// AdvancedVisibilityStore holds the advanced visibility datastore specs.
// +optional
AdvancedVisibilityStore *DatastoreSpec `json:"advancedVisibilityStore,omitempty"`
}
Expand Down Expand Up @@ -517,7 +517,7 @@ func (p *TemporalPersistenceSpec) GetDatastoresMap() map[string]*DatastoreSpec {

// TemporalUIIngressSpec contains all configurations options for the UI ingress.
type TemporalUIIngressSpec struct {
// Annotations allows custom annotations on the ingress ressource.
// Annotations allows custom annotations on the ingress resource.
Annotations map[string]string `json:"annotations,omitempty"`
// IngressClassName is the name of the IngressClass the deployed ingress resource should use.
IngressClassName *string `json:"ingressClassName,omitempty"`
Expand Down Expand Up @@ -708,7 +708,7 @@ type PrometheusScrapeConfigServiceMonitor struct {
// +optional
Labels map[string]string `json:"labels,omitempty"`
// Override allows customization of the created ServiceMonitor.
// All fields can be overritten except "endpoints", "selector" and "namespaceSelector".
// All fields can be overwritten except "endpoints", "selector" and "namespaceSelector".
// +optional
Override *monitoringv1.ServiceMonitorSpec `json:"override,omitempty"`
// MetricRelabelConfigs to apply to samples before ingestion.
Expand Down Expand Up @@ -796,7 +796,7 @@ type DynamicConfigSpec struct {
// Defaults to 10s.
// +optional
PollInterval *metav1.Duration `json:"pollInterval"`
// Values contains all dynamic config keys and their constained values.
// Values contains all dynamic config keys and their constrained values.
Values map[string][]ConstrainedValue `json:"values"`
}

Expand Down Expand Up @@ -858,7 +858,7 @@ func (p *ArchivalProvider) Kind() ArchivalProviderKind {
return UnknownArchivalProviderKind
}

// ArchivalSpec is the archival configuration for a particular persistence type (history or visibilitty).
// ArchivalSpec is the archival configuration for a particular persistence type (history or visibility).
type ArchivalSpec struct {
// Enabled defines if the archival is enabled by default for all namespaces
// or for a particular namespace (depends if it's for a TemporalCluster or a TemporalNamespace).
Expand Down Expand Up @@ -1039,7 +1039,7 @@ type DatastoreStatus struct {
Created bool `json:"created"`
// Setup indicates if tables have been set up.
Setup bool `json:"setup"`
// Type indicates the datastore stype.
// Type indicates the datastore type.
// +optional
Type DatastoreType `json:"type"`
// SchemaVersion report the current schema version.
Expand All @@ -1056,7 +1056,7 @@ type TemporalPersistenceStatus struct {
// SecondaryVisibilityStore holds the secondary visibility datastore status.
// +optional
SecondaryVisibilityStore *DatastoreStatus `json:"secondaryVisibilityStore"`
// AdvancedVisibilityStore holds the avanced visibility datastore status.
// AdvancedVisibilityStore holds the advanced visibility datastore status.
// +optional
AdvancedVisibilityStore *DatastoreStatus `json:"advancedVisibilityStore,omitempty"`
}
Expand Down
Loading