test: fix e2e test kind setup #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrevilain
requested changes
Apr 4, 2024
tests/e2e/main_test.go
Outdated
| @@ -62,6 +64,46 @@ func TestMain(m *testing.M) { | |||
| os.Exit(testMainRun(m)) | |||
| } | |||
|
|
|||
| type FixedKindProvider struct { | |||
There was a problem hiding this comment.
Could you please move this in another file ?
Could you also add a comment that this wrapper around the kind cluster is existing in the codebase while waiting for kubernetes-sigs/e2e-framework#395 to be merged ?
There was a problem hiding this comment.
Sounds good. I've also changed the KUBERNETES_VERSION check so that it's skipped when not set or empty. Helpful for running e2e test locally regardless of the K8s version.
alexandrevilain
approved these changes
Apr 8, 2024
|
Hi @jashandeep-sohi ! Could you please squash your commits? Thanks! |
jashandeep-sohi
force-pushed
the
fix/e2e-kind-version
branch
from
e1747d2 to
21250fa
Compare
|
alexandrevilain
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #675